Add API for restricting operations for sensitive files by trancexpress · Pull Request #2597 · eclipse-platform/eclipse.platform

trancexpress · 2026-03-30T08:41:02Z

This change adds the following API:

org.eclipse.core.resources.IFile.isContentRestricted()
org.eclipse.core.resources.IFile.setContentRestricted(boolean)

The goal of this API is to allow Eclipse-based IDEs to restrict certain
platform functionality on a per-file basis, for sensitive files.

The flags are not persisted, to enable restricted handling
these flags must be set for each session.

The restrictions will apply to following functionality:

File search
Storing file history

Potentially more platform functionality will be restricted.

See: #2588

trancexpress · 2026-03-30T08:44:54Z

@merks if you can help with the API documentation wording, that would be great!

...org.eclipse.core.resources/src/org/eclipse/core/internal/resources/WorkspaceDescription.java

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java

github-actions · 2026-03-30T09:16:44Z

Test Results

54 files ±0 54 suites ±0 37m 26s ⏱️ + 1m 25s
4 547 tests +1 4 524 ✅ +1 23 💤 ±0 0 ❌ ±0
12 237 runs +3 12 078 ✅ +3 159 💤 ±0 0 ❌ ±0

Results for commit 8fbeb32. ± Comparison against base commit e02781c.

♻️ This comment has been updated with latest results.

merks · 2026-03-30T09:18:36Z

@merks if you can help with the API documentation wording, that would be great!

FYI. I’m on vacation mostly monitoring from my iPhone with slow internet. Ping me when you think it’s done and I can look at it on my computer later.

...org.eclipse.core.resources/src/org/eclipse/core/internal/resources/WorkspaceDescription.java

iloveeclipse

LGTM for me, just white space change on WorkspaceDescription should be reverted.

Copilot

Pull request overview

Adds a new session-scoped API in org.eclipse.core.resources to mark files as “restricted/sensitive” and to globally enable/disable restricted-content handling at the workspace level, intended to let downstream IDEs disable content-related operations for those files.

Changes:

Add IWorkspace.isRestrictedContentEnabled() / setRestrictedContentEnabled(boolean) workspace toggle.
Add IFile.isContentRestricted() / setContentRestricted(boolean) backed by a session property (RESTRICTED_CONTENT).
Implement the workspace toggle in internal Workspace and bump bundle version.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IWorkspace.java	Adds new workspace-level restricted-content enablement API + Javadoc.
resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java	Adds session-property key and default methods for per-file restricted-content marking.
resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/Workspace.java	Implements the new `IWorkspace` API via an internal boolean flag.
resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/WorkspaceDescription.java	Whitespace-only change.
resources/bundles/org.eclipse.core.resources/META-INF/MANIFEST.MF	Bumps bundle version to 3.24.0.qualifier.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IWorkspace.java

...es/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/Workspace.java

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java

....core.tests.resources/src/org/eclipse/core/tests/internal/resources/RestrictedFileTests.java

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java

iloveeclipse · 2026-03-30T15:50:29Z

From my POV this PR is ready to merge, so

@laeubi : please check the proposed API.
@merks : if you could look at wording, would be great.

laeubi

See comments below, I think the API exposure can be reduced a bit.

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IWorkspace.java

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java

merks

The wording looks fine. I'm not sure if a @param/@throws/@return description is supposed to end with a period. This is a bit inconsistent across the Javadoc entries.

iloveeclipse

LGTM.

iloveeclipse · 2026-03-31T08:35:37Z

@laeubi : anything else? If no, let's merge that.

laeubi

It looks all clean and consistent to me and adding only minimal and reusable API.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/File.java

....core.tests.resources/src/org/eclipse/core/tests/internal/resources/RestrictedFileTests.java

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java

laeubi

Looks good to me.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/File.java

This change adds the following API: * org.eclipse.core.resources.IFile.isContentRestricted() * org.eclipse.core.resources.IFile.setContentRestricted(boolean) The goal of this API is to allow Eclipse-based IDEs to restrict certain platform functionality on a per-file basis, for sensitive files. The flags are not persisted, to enable restricted handling these flags must be set for each session. The restrictions will apply to following functionality: * File search * Storing file history Potentially more platform functionality will be restricted. See: eclipse-platform#2588

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java

iloveeclipse · 2026-03-31T12:13:40Z

Thanks all (including Copilot :-)), merging.

trancexpress requested review from iloveeclipse and laeubi March 30, 2026 08:41

trancexpress force-pushed the gh2588_with_api branch from 7c9b138 to 6aaeb1d Compare March 30, 2026 08:41

trancexpress mentioned this pull request Mar 30, 2026

Add preference for disabling history on restricted files #2589

Merged

trancexpress commented Mar 30, 2026

View reviewed changes

...org.eclipse.core.resources/src/org/eclipse/core/internal/resources/WorkspaceDescription.java Show resolved Hide resolved

iloveeclipse reviewed Mar 30, 2026

View reviewed changes

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java Outdated Show resolved Hide resolved

trancexpress force-pushed the gh2588_with_api branch from 6aaeb1d to fa30d36 Compare March 30, 2026 11:54

iloveeclipse reviewed Mar 30, 2026

View reviewed changes

...org.eclipse.core.resources/src/org/eclipse/core/internal/resources/WorkspaceDescription.java Outdated Show resolved Hide resolved

iloveeclipse requested a review from Copilot March 30, 2026 12:50

iloveeclipse approved these changes Mar 30, 2026

View reviewed changes

Copilot started reviewing on behalf of iloveeclipse March 30, 2026 12:51 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

trancexpress force-pushed the gh2588_with_api branch 4 times, most recently from e8b9816 to 9c81084 Compare March 30, 2026 15:09

iloveeclipse reviewed Mar 30, 2026

View reviewed changes

....core.tests.resources/src/org/eclipse/core/tests/internal/resources/RestrictedFileTests.java Outdated Show resolved Hide resolved

iloveeclipse reviewed Mar 30, 2026

View reviewed changes

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java Outdated Show resolved Hide resolved

trancexpress force-pushed the gh2588_with_api branch from 9c81084 to 34da22a Compare March 30, 2026 15:39

iloveeclipse approved these changes Mar 30, 2026

View reviewed changes

laeubi reviewed Mar 31, 2026

View reviewed changes

trancexpress force-pushed the gh2588_with_api branch 2 times, most recently from fcf3236 to f216b6c Compare March 31, 2026 06:47

merks reviewed Mar 31, 2026

View reviewed changes

trancexpress force-pushed the gh2588_with_api branch 2 times, most recently from 8aa8740 to 1771aa1 Compare March 31, 2026 08:20

trancexpress force-pushed the gh2588_with_api branch 3 times, most recently from 584c8e3 to 1e2f103 Compare March 31, 2026 08:32

iloveeclipse approved these changes Mar 31, 2026

View reviewed changes

laeubi approved these changes Mar 31, 2026

View reviewed changes

laeubi requested a review from Copilot March 31, 2026 08:53

Copilot started reviewing on behalf of laeubi March 31, 2026 08:54 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

trancexpress force-pushed the gh2588_with_api branch 2 times, most recently from a569970 to 86b0323 Compare March 31, 2026 09:19

iloveeclipse approved these changes Mar 31, 2026

View reviewed changes

laeubi reviewed Mar 31, 2026

View reviewed changes

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java Outdated Show resolved Hide resolved

trancexpress force-pushed the gh2588_with_api branch from 86b0323 to da7b8ab Compare March 31, 2026 09:39

laeubi approved these changes Mar 31, 2026

View reviewed changes

laeubi requested a review from Copilot March 31, 2026 09:40

Copilot started reviewing on behalf of laeubi March 31, 2026 09:41 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

trancexpress force-pushed the gh2588_with_api branch 2 times, most recently from d360cdc to 3a5a9a3 Compare March 31, 2026 11:09

laeubi reviewed Mar 31, 2026

View reviewed changes

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/File.java Outdated Show resolved Hide resolved

trancexpress force-pushed the gh2588_with_api branch from 3a5a9a3 to 9b99e83 Compare March 31, 2026 11:33

trancexpress force-pushed the gh2588_with_api branch from 9b99e83 to 8fbeb32 Compare March 31, 2026 11:37

laeubi requested a review from Copilot March 31, 2026 11:38

Copilot started reviewing on behalf of laeubi March 31, 2026 11:38 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java Show resolved Hide resolved

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/IFile.java Show resolved Hide resolved

iloveeclipse approved these changes Mar 31, 2026

View reviewed changes

iloveeclipse merged commit e85fd97 into eclipse-platform:master Mar 31, 2026
22 checks passed

Conversation

trancexpress commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trancexpress commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

merks commented Mar 30, 2026

Uh oh!

Uh oh!

iloveeclipse left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iloveeclipse commented Mar 30, 2026

Uh oh!

laeubi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

merks left a comment

Choose a reason for hiding this comment

Uh oh!

iloveeclipse left a comment

Choose a reason for hiding this comment

Uh oh!

iloveeclipse commented Mar 31, 2026

Uh oh!

laeubi left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

laeubi left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

iloveeclipse commented Mar 31, 2026

Uh oh!

trancexpress commented Mar 30, 2026 •

edited

Loading

trancexpress commented Mar 30, 2026 •

edited

Loading

github-actions bot commented Mar 30, 2026 •

edited

Loading